Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow receiving an array of sites as CORS ORIGIN #740

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio commented Apr 12, 2024

This PR allows receiving as query parameter, an array of sites to be used as the CORS_ORIGIN environment variable.

@coveralls
Copy link

coveralls commented Apr 12, 2024

Pull Request Test Coverage Report for Build 8677062401

Details

  • 5 of 9 (55.56%) changed or added relevant lines in 2 files are covered.
  • 39 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 70.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/server.ts 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
src/Item/Item.service.ts 17 89.52%
src/Item/Item.model.ts 22 12.5%
Totals Coverage Status
Change from base Build 8567389305: -0.2%
Covered Lines: 2938
Relevant Lines: 4034

💛 - Coveralls

@LautaroPetaccio LautaroPetaccio merged commit 3387a3e into master Apr 15, 2024
4 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/allow-list-of-cors-origins branch April 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants