Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch default & created by the user asset packs #1579

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

LautaroPetaccio
Copy link
Contributor

This PR uses the new query parameter to fetch simultaneously the asset packs created by the user and the default ones.

@vercel
Copy link

vercel bot commented Sep 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/decentraland/builder/ASqtY2zdYbFcRoMcmnUNjGZQpsHs
✅ Preview: https://builder-git-feat-query-asset-packs-individually-decentraland1.vercel.app

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1263414383

  • 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 5.403%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/assetPack/sagas.ts 0 3 0.0%
src/lib/api/builder.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/modules/assetPack/sagas.ts 2 0%
Totals Coverage Status
Change from base Build 1259284901: -0.005%
Covered Lines: 579
Relevant Lines: 8946

💛 - Coveralls

Copy link
Contributor

@nachomazzara nachomazzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cazala cazala merged commit f1ccf55 into master Sep 23, 2021
@cazala cazala deleted the feat/query-asset-packs-individually branch September 23, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants