feat: Request review for updated collection items

[fzavalia]

Issue #1546

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/decentraland/builder/CQgy75TqoFYiSn6iW4byWBRycysM
✅ Preview: https://builder-git-feat-ready-for-review-decentraland1.vercel.app

[coveralls]

Pull Request Test Coverage Report for Build 1313590951

• 95 of 182 (52.2%) changed or added relevant lines in 25 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.9%) to 10.062%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/Modals/index.ts	0	1	0.0%
src/modules/common/reducer.ts	0	1	0.0%
src/components/CollectionDetailPage/CollectionAction/UnderReview/index.ts	0	2	0.0%
src/components/CollectionDetailPage/CollectionAction/index.ts	0	2	0.0%
src/components/CollectionProvider/CollectionProvider.container.ts	0	2	0.0%
src/components/Modals/PushCollectionChangesModal/index.ts	0	2	0.0%
src/components/Modals/SellCollectionModal/SellCollectionModal.container.ts	0	2	0.0%
src/modules/committee/sagas.ts	0	2	0.0%
src/modules/common/sagas.ts	0	2	0.0%
src/modules/curation/reducer.ts	17	19	89.47%

Files with Coverage Reduction	New Missed Lines	%
src/components/CollectionProvider/CollectionProvider.container.ts	1	0%

Totals
Change from base Build 1313555770:	0.9%
Covered Lines:	1069
Relevant Lines:	9268

---

💛 - Coveralls

[cazala]

mm I usually advise against creating this kind of types, like if we have a type Thing = { otherId: string } and a type Other = { ... } it might be tempting to create a type ThingWithOther = Thing & { other: Other } but sooner than later that can become a typing hell with multiple flavors of Thing... I lean towards keeping types canonical and connect components via redux to get data from other domains, ie:

Instead of this:

type ThingWithOther = {
  other?: Other
}

type Props {
  thing: ThingWithOther
}

Doing this:

type Props = {
  thing: Thing
  other?: Other
}

And connecting it like this:

const mapState = (state: RootState, { thingId }: OwnProps) => {
  const things = getThings(state)
  const thing = things[thingId]
  const others = getOthers(state)
  const other = others[thing.otherId]
  return {
    thing,
    other
  } 
}

And if you need to connect an array of Thing[] you can simply connect a record of Record<string, Other>

type Props = {
  things: Thing[]
  othersById: Record<string, Other>
}

And connect within the component:

const { things, othersById } = props
const others = things.map(thing => othersById[thing.otherId]) // some random array operation dependant on Other

[fzavalia]

Sorry that I merged before addressing this comment, Github only showed me the approval but no comments.
#1589 This PR addresses it 😄