Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove FF for templates, smart wearables, hands and deploy to worlds #2922

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

meelrossi
Copy link
Contributor

Remove FF for features that have been deployed for a long time

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:23pm

@@ -78,14 +46,6 @@ export const getIsSmartItemsEnabled = (state: RootState) => {
}
}

export const getIsNewNavbarEnabled = (state: RootState) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reapeated

@coveralls
Copy link

coveralls commented Sep 27, 2023

Pull Request Test Coverage Report for Build 6339462052

  • 1 of 36 (2.78%) changed or added relevant lines in 11 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.003%) to 17.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/CollectionsPage/CollectionsPage.tsx 0 1 0.0%
src/components/Modals/CreateSingleItemModal/ImportStep/ImportStep.tsx 0 1 0.0%
src/components/Modals/DeployModal/DeployToLand/DeployToLand.tsx 0 1 0.0%
src/components/SceneViewPage/SceneViewPage.tsx 0 1 0.0%
src/modules/item/utils.ts 0 1 0.0%
src/components/Modals/ExportModal/ExportModal.tsx 0 2 0.0%
src/components/Navigation/Navigation.tsx 0 2 0.0%
src/modules/project/sagas.ts 1 3 33.33%
src/components/ScenesPage/ScenesPage.tsx 0 3 0.0%
src/components/Modals/CreateSingleItemModal/CreateSingleItemModal.tsx 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/ItemEditorPage/RightPanel/RightPanel.tsx 1 0.0%
src/components/Modals/DeployModal/DeployToLand/DeployToLand.tsx 1 0.0%
src/modules/features/selectors.ts 1 50.0%
src/modules/item/utils.ts 2 36.67%
Totals Coverage Status
Change from base Build 6338825128: -0.003%
Covered Lines: 3474
Relevant Lines: 16220

💛 - Coveralls

onOpenModal('CustomLayoutModal')
}
}, [isTemplatesEnabled, onOpenModal])
onOpenModal('SceneCreationModal')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the CustomLayoutModal being used elsewhere or it can be deleted?

Copy link
Contributor

@cyaiox cyaiox Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomLayoutModal is used when creating a new scene from scratch

@meelrossi meelrossi merged commit 2f176ac into master Sep 28, 2023
7 checks passed
@meelrossi meelrossi deleted the feat/remove-ff branch September 28, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants