Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add function to fetch wallet world stats to the worlds api #2925

Merged
merged 2 commits into from
Sep 29, 2023
Merged

feat: Add function to fetch wallet world stats to the worlds api #2925

merged 2 commits into from
Sep 29, 2023

Conversation

fzavalia
Copy link
Contributor

  • Changed the name of the function to fetch external names so it is similar to the rest of the app

Closes #2911

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 5:04pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6354678433

  • 6 of 11 (54.55%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 17.194%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/api/worlds.ts 4 9 44.44%
Totals Coverage Status
Change from base Build 6354204294: 0.02%
Covered Lines: 3493
Relevant Lines: 16299
💛 - Coveralls

LautaroPetaccio
LautaroPetaccio approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fzavalia fzavalia merged commit 08a5123 into master Sep 29, 2023
7 checks passed
@fzavalia fzavalia deleted the feat/fetch-wallet-stats branch September 29, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LautaroPetaccio LautaroPetaccio LautaroPetaccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create client to request the current storage used and available storage for the current user
3 participants
@fzavalia @coveralls @LautaroPetaccio