-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show real data in worlds storage component #2930
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 6384626300
💛 - Coveralls |
if (!address) { | ||
const { | ||
success | ||
}: { | ||
success: ConnectWalletSuccessAction | ||
failure: ConnectWalletFailureAction | ||
} = yield race({ | ||
success: take(CONNECT_WALLET_SUCCESS), | ||
failure: take(CONNECT_WALLET_FAILURE) | ||
}) | ||
|
||
if (success) { | ||
address = success.payload.wallet.address | ||
} else { | ||
throw new Error('An address is required') | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be assuming that if it doesn't have an address, the process to connect to it is happening while this saga is executing. Could it happen to this saga to be executed when there's no wallet and the process to connect to the wallet is not in progress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for the purpose it is implemented for.
It could be the case that you would like to call the function without providing an address but not being connected but it makes no sense at all. It will just wait until you are connected.
Closes #2929
Uses real data from the endpoint: