Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show real data in worlds storage component #2930

Merged
merged 9 commits into from
Oct 2, 2023

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Oct 2, 2023

Closes #2929

Screenshot 2023-10-02 at 12 00 47

Uses real data from the endpoint:

GET https://worlds-content-server.decentraland.zone/wallet/0x24e5f44999c151f08609f8e27b2238c773c4d020/stats

{
    "wallet": "0x24e5f44999c151f08609f8e27b2238c773c4d020",
    "dclNames": [
        {
            "name": "nan2.dcl.eth",
            "size": "780813"
        },
        {
            "name": "niswoman.dcl.eth",
            "size": "1206426"
        },
        {
            "name": "alberto.dcl.eth",
            "size": "1012688"
        }
    ],
    "ensNames": [
        {
            "name": "luffy.eth",
            "size": "1012682"
        }
    ],
    "usedSpace": "2999927",
    "maxAllowedSpace": "15728640000"
}

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 7:39pm

@coveralls
Copy link

coveralls commented Oct 2, 2023

Pull Request Test Coverage Report for Build 6384626300

  • 15 of 21 (71.43%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 17.425%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/worlds/selectors.ts 4 5 80.0%
src/components/WorldListPage_WorldsForEnsOwnersFeature/WorldListPage.container.ts 0 2 0.0%
src/components/WorldListPage_WorldsForEnsOwnersFeature/WorldListPage.tsx 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/WorldListPage_WorldsForEnsOwnersFeature/WorldListPage.tsx 1 0.0%
Totals Coverage Status
Change from base Build 6384377484: 0.05%
Covered Lines: 3551
Relevant Lines: 16361

💛 - Coveralls

Comment on lines +29 to +45
if (!address) {
const {
success
}: {
success: ConnectWalletSuccessAction
failure: ConnectWalletFailureAction
} = yield race({
success: take(CONNECT_WALLET_SUCCESS),
failure: take(CONNECT_WALLET_FAILURE)
})

if (success) {
address = success.payload.wallet.address
} else {
throw new Error('An address is required')
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be assuming that if it doesn't have an address, the process to connect to it is happening while this saga is executing. Could it happen to this saga to be executed when there's no wallet and the process to connect to the wallet is not in progress?

Copy link
Contributor Author

@fzavalia fzavalia Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the purpose it is implemented for.

It could be the case that you would like to call the function without providing an address but not being connected but it makes no sense at all. It will just wait until you are connected.

@fzavalia fzavalia merged commit f97b3dd into master Oct 2, 2023
7 checks passed
@fzavalia fzavalia deleted the feat/integrate-fetch-world-wallet-stats branch October 2, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch worlds wallet stats to display in the worlds storage component
3 participants