feat: Your storage modal #2941
Merged
feat: Your storage modal #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fzavalia
force-pushed
the
feat/your-storage-modal
branch
from
1b8ab53
to
ba26d90
Compare
Pull Request Test Coverage Report for Build 6419985967
💛 - Coveralls |
| import { connect } from 'react-redux' | ||
| import WalletLoginModal from './WorldsYourStorageModal' | ||
|
|
||
| export default connect(null, null)(WalletLoginModal) |
There was a problem hiding this comment.
This file is connecting two nulled values, should we remove it?
| @@ -37,7 +38,8 @@ const mapState = (state: RootState): MapStateProps => ({ | |||
| }) | |||
|
|
|||
| const mapDispatch = (dispatch: MapDispatch): MapDispatchProps => ({ | |||
| onNavigate: path => dispatch(push(path)) | |||
| onNavigate: path => dispatch(push(path)), | |||
| onOpenModal: (name, metadata) => dispatch(openModal(name, metadata)) | |||
There was a problem hiding this comment.
It the only modal that's going to be opened is the one you know, you can fix the name here.
Suggested change
| onOpenModal: (name, metadata) => dispatch(openModal(name, metadata)) | |
| onOpenModal: (metadata) => dispatch(openModal('WorldsYourStorageModal', metadata)) |
| @@ -19,6 +21,7 @@ export type Props = { | |||
| isLoading: boolean | |||
| worldsWalletStats?: WorldsWalletStats | |||
| onNavigate: (path: string) => void | |||
| onOpenModal: (name: Parameters<typeof openModal>[0], metadata: WorldsYourStorageModalMetadata) => void | |||
There was a problem hiding this comment.
This can be simplified if the name parameter is removed:
Suggested change
| onOpenModal: (name: Parameters<typeof openModal>[0], metadata: WorldsYourStorageModalMetadata) => void | |
| onOpenModal: (metadata: WorldsYourStorageModalMetadata) => void |
| } as Response) | ||
| }) | ||
|
|
||
| it('should return null', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should return null', async () => { | |
| it('should return the account holdings', async () => { |
fzavalia
force-pushed
the
feat/your-storage-modal
branch
from
ba26d90
to
4b835b7
Compare
LautaroPetaccio
approved these changes
Oct 5, 2023
LautaroPetaccio
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2919