Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow publishing world when only owning ens names #2943

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Oct 4, 2023

Closes #2907

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 8:36pm

@@ -355,19 +355,7 @@ export default function DeployToWorld({
<>
<div className={styles.modalHeader}>
<h3>{t('deployment_modal.deploy_world.title')}</h3>
<span>
{t('deployment_modal.deploy_world.description')}
<Popup
Copy link
Contributor Author

@fzavalia fzavalia Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the popup as there is no info to add (lorem ipsum is not valid xd)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6411171680

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 17.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Modals/DeployModal/DeployToWorld_WorldsForEnsOwnersFeature/DeployToWorld.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 6408157138: -0.001%
Covered Lines: 3583
Relevant Lines: 16425

💛 - Coveralls

@fzavalia fzavalia merged commit 841500a into master Oct 4, 2023
7 checks passed
@fzavalia fzavalia deleted the fix/allow-when-own-ens branch October 4, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to publish world when they have no DCL Names but yes another ENS names
3 participants