Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unpublish world #2946

Merged
merged 7 commits into from
Oct 5, 2023
Merged

feat: Unpublish world #2946

merged 7 commits into from
Oct 5, 2023

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Oct 5, 2023

Closes #2944

@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 5:47pm

@coveralls
Copy link

coveralls commented Oct 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6422543960

  • 15 of 24 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 17.63%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/deployment/sagas.ts 15 24 62.5%
Totals Coverage Status
Change from base Build 6420984498: 0.1%
Covered Lines: 3616
Relevant Lines: 16462
💛 - Coveralls

@fzavalia fzavalia marked this pull request as ready for review October 5, 2023 17:10
@fzavalia fzavalia merged commit cf3fbb9 into master Oct 5, 2023
7 checks passed
@fzavalia fzavalia deleted the feat/unpublish-world branch October 5, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LautaroPetaccio LautaroPetaccio LautaroPetaccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use undeploy endpoint to undeploy a world
3 participants
@fzavalia @coveralls @LautaroPetaccio