fix: Re-request wallet stats

[fzavalia]

On clear deployment and deployment success

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
builder	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 6, 2023 3:08pm

[coveralls]

Pull Request Test Coverage Report for Build 6433283166

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 17.647%

---

Totals
Change from base Build 6432949052:	0.02%
Covered Lines:	3619
Relevant Lines:	16465

---

💛 - Coveralls

[LautaroPetaccio]

As expectSaga runs the saga until completion and, when testing handleActionsThatTriggerFetchWorldsWalletStatsRequest, the fetchWorldsWalletStatsRequest action is put and, taking into consideration that the sagas also handles that action, the fetchWorldsWalletStatsRequest should be ran as well. To prevent this, we can mock the put:

Suggested change

	.provide([[select(getAddress), address]])
	.provide([[select(getAddress), address], [put(fetchWorldsWalletStatsRequest(address)), undefined]])

[fzavalia]

I'm certain that is unnecessary due to the nature of sagas.

fetchWorldsWalletStatsRequest will be handled by the saga yes, but it will not proceed on any undeclared effect.

For example, it will run and stop were said in the code:

function* handlefetchWorldsWalletStatsRequest(action: FetchWalletWorldsStatsRequestAction) {
  const { address } = action.payload

  try {
    // Stops here given that the call is not declared in the test
    const stats: WorldsWalletStats | null = yield call([WorldsAPIContent, WorldsAPIContent.fetchWalletStats], address)

[fzavalia]

Besides if I set the request put in the .provide, it will not call the .put that comes afterwards, making the test not declaratively useful given that the things tested are what comes after the .provide

[fzavalia]

I'm mistaken with this, updated it per your suggestion