Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collection name with emoji #2981

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: collection name with emoji #2981

merged 1 commit into from
Nov 7, 2023

Conversation

meelrossi
Copy link
Contributor

Change regex to remove any non ascii character from base64 wearable

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 9:00pm

@coveralls
Copy link

coveralls commented Nov 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6776400539

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 17.691%
Totals Coverage Status
Change from base Build 6669649342: 0.0%
Covered Lines: 3637
Relevant Lines: 16522
💛 - Coveralls

fzavalia
fzavalia reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@fzavalia fzavalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect in anyway the publishing of the wearable or is it purely for the ui?

@meelrossi
Copy link
Contributor Author

This is only being used to send the base64 wearable to the wearable-preview. And from what i've seen its not even being used the name and description in the wearable preview.

@meelrossi meelrossi merged commit 611abce into master Nov 7, 2023
7 checks passed
@meelrossi meelrossi deleted the fix/emoji-collection branch November 7, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzavalia fzavalia fzavalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meelrossi @coveralls @fzavalia