feat: names detail page #3018
Merged
feat: names detail page #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meelrossi
commented
Jan 19, 2024
meelrossi
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 7620032285
💛 - Coveralls |
| export default function ENSDetailPage(props: Props) { | ||
| const { ens, isLoading, alias, avatar, name, onNavigate, onOpenModal, onFetchENS } = props | ||
| const imgUrl = useMemo<string>( | ||
| () => (ens ? `http://marketplace-api.decentraland.zone/v1/ens/generate?ens=${ens.name}&width=330&height=330` : ''), |
There was a problem hiding this comment.
Would you mind getting the marketplace-api url from the config files?
| <img | ||
| className="ens-list-name-icon" | ||
| alt={ens.subdomain} | ||
| src={`http://marketplace-api.decentraland.zone/v1/ens/generate?ens=${ens.name}&width=330&height=330`} |
There was a problem hiding this comment.
Same as before (just as a reminder), would you mind moving the marketplace-api site URL to the configs?
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Melisa Anabella Rossi <merossi@itba.edu.ar>
…der into feat/names-detail-page
LautaroPetaccio
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.