feat: Build site using Vite #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 7660493092
💛 - Coveralls |
cyaiox
reviewed
Jan 25, 2024
index.html
Outdated
| @@ -2,7 +2,7 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8" /> | |||
| <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico" /> | |||
| <!-- <link rel="shortcut icon" href="%VITE_BASE_URL%/favicon.ico" /> --> | |||
src/modules/worlds/sagas.ts
Outdated
| @@ -31,7 +32,7 @@ function* handlefetchWorldsWalletStatsRequest(action: FetchWalletWorldsStatsRequ | |||
|
|
|||
| yield put(fetchWorldsWalletStatsSuccess(address, stats)) | |||
| } catch (e) { | |||
| yield put(fetchWorldsWalletStatsFailure(address, e.message)) | |||
| yield put(fetchWorldsWalletStatsFailure(address, isErrorWithMessage(e) ? e.message : 'Unknown')) | |||
There was a problem hiding this comment.
Suggested change
| yield put(fetchWorldsWalletStatsFailure(address, isErrorWithMessage(e) ? e.message : 'Unknown')) | |
| yield put(fetchWorldsWalletStatsFailure(address, isErrorWithMessage(e) ? e.message : 'Unknown error')) |
src/modules/project/export.ts
Outdated
| import * as ECS from 'decentraland-ecs' | ||
| import { SceneWriter, LightweightWriter } from 'dcl-scene-writer' | ||
| import packageJson from 'decentraland/samples/ecs/package.json' | ||
| import { isErrorWithMessage } from 'decentraland-dapps/dist/lib/error' | ||
| import sceneJsonSample from 'decentraland/samples/ecs/scene.json' |
There was a problem hiding this comment.
is it possible to lazy load this one too?
import sceneJsonSample from 'decentraland/samples/ecs/scene.json'
src/modules/common/store.ts
Outdated
| @@ -40,15 +40,10 @@ import { rootSaga } from './sagas' | |||
| import { RootState, RootStore } from './types' | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
| const builderVersion = require('../../../package.json').version | |||
| // const builderVersion = require('../../../package.json').version | |||
src/lib/date.ts
Outdated
| @@ -39,6 +39,7 @@ export function formatTime(seconds: number) { | |||
| } | |||
|
|
|||
| function includeLocale(options: Options): Options { | |||
| console.log('Current locale', getCurrentLocale) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the build mechanism to use Vite.
It also:
isErrorWithMessagewhich was required due to the TS upgrade.modules/modals/actions