Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit metadata #3026

Merged
merged 13 commits into from
Jan 31, 2024
Merged

feat: edit metadata #3026

merged 13 commits into from
Jan 31, 2024

Conversation

cazala
Copy link
Member

@cazala cazala commented Jan 27, 2024

Enable scene metadata inspector in web editor

Screenshot 2024-01-26 at 23 25 34

@cazala cazala requested a review from cyaiox January 27, 2024 02:28
Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ❌ Failed (Inspect) Jan 31, 2024 1:42pm

@coveralls
Copy link

coveralls commented Jan 27, 2024

Pull Request Test Coverage Report for Build 7726876825

  • -43 of 47 (8.51%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 46.224%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/inspector/utils.ts 1 4 25.0%
src/modules/deployment/sagas.ts 1 5 20.0%
src/modules/project/utils.ts 1 8 12.5%
src/modules/inspector/sagas.ts 1 30 3.33%
Files with Coverage Reduction New Missed Lines %
src/modules/inspector/sagas.ts 4 11.46%
Totals Coverage Status
Change from base Build 7717410250: -0.2%
Covered Lines: 5272
Relevant Lines: 10321

💛 - Coveralls

package.json Outdated
@@ -10,6 +10,7 @@
"@dcl/content-hash-tree": "^1.1.3",
"@dcl/crypto": "^3.4.5",
"@dcl/hashing": "^3.0.4",
"@dcl/inspector": "^7.3.40",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required to install the @dcl/inspector package or we could upgrade the @dcl/sdk package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh you are right, it’s the sdk we have to update

@cazala cazala enabled auto-merge (squash) January 31, 2024 13:33
@cazala cazala disabled auto-merge January 31, 2024 13:33
@cazala cazala enabled auto-merge (squash) January 31, 2024 13:33
@cazala cazala merged commit 7a9fce1 into master Jan 31, 2024
5 of 6 checks passed
@cazala cazala deleted the feat/edit-metadata branch January 31, 2024 13:36
Copy link

sentry-io bot commented Feb 7, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: i is null nQ.render(@dcl/builder-site/src/components/Moda... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants