Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove iframe from sso #3038

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix: Remove iframe from sso #3038

merged 3 commits into from
Feb 8, 2024

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Feb 7, 2024

No description provided.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 9:47am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7812821478

  • -8 of 11 (27.27%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/api/auth.ts 1 2 50.0%
src/lib/api/builder.ts 1 3 33.33%
src/modules/identity/sagas.ts 1 6 16.67%
Totals Coverage Status
Change from base Build 7805240085: 0.0%
Covered Lines: 5272
Relevant Lines: 10322

💛 - Coveralls

@@ -558,7 +558,7 @@ export class BuilderAPI extends BaseAPI {
headers = { ...config.headers }
}
}
const authHeaders = await this.authorization.createAuthHeaders(method, path)
const authHeaders = this.authorization.createAuthHeaders(method, path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the method createAuthHeaders no longer async?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer async :D

@fzavalia fzavalia merged commit 85fac60 into master Feb 8, 2024
7 checks passed
@fzavalia fzavalia deleted the fix/remove-sso branch February 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants