Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate skin size #3051

Merged
merged 28 commits into from
Apr 5, 2024
Merged

feat: validate skin size #3051

merged 28 commits into from
Apr 5, 2024

Conversation

braianj
Copy link
Contributor

@braianj braianj commented Mar 1, 2024 •
edited
Loading

Here are some examples that I used to test:

Some of the messages

Screenshot 2024-03-26 at 7 07 31 PM Screenshot 2024-03-26 at 7 08 04 PM Screenshot 2024-03-26 at 7 08 34 PM Screenshot 2024-03-26 at 7 10 31 PM

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 0:38am

@braianj braianj changed the title feat: first step validation new skin size feat: validate skin size Mar 1, 2024
@braianj braianj mentioned this pull request Mar 1, 2024
Open
10 tasks
@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8569885392

Details

  • 28 of 32 (87.5%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 46.038%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/export.ts 0 4 0.0%
Totals Coverage Status
Change from base Build 8560730843: 0.1%
Covered Lines: 5208
Relevant Lines: 10289
💛 - Coveralls

@braianj braianj self-assigned this Mar 26, 2024
@Ludmilafantaniella
Copy link

Currently, the error message for thumbnail uploads appears after the user completes all the information and tries to save it. It should appear immediately after uploading a thumbnail that exceeds the size limit to avoid wasting the user's time. Additionally, it should allow the user to select another thumbnail directly from the 'New Item' pop-up.

thumbnail exceeds

Ludmilafantaniella
Ludmilafantaniella approved these changes Apr 5, 2024
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed and approved by QA. Testing Results

@braianj braianj merged commit 1d3b0e4 into master Apr 5, 2024
7 checks passed
@braianj braianj deleted the feat/wearables-size branch April 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

@juanmahidalgo juanmahidalgo Awaiting requested review from juanmahidalgo

@LautaroPetaccio LautaroPetaccio Awaiting requested review from LautaroPetaccio

Assignees

@braianj braianj

Labels
None yet
Projects
Platform Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@braianj @coveralls @Ludmilafantaniella @LautaroPetaccio