-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use wert for collection fees #3058
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 8393232998Details
💛 - Coveralls |
}) | ||
|
||
// TODO: Test the rest of the saga. | ||
// Not included in this PR given that I don't know how to test event channels yet. 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
partnerId = '01HRRQQ70YK4SP88GHM9A61P6B' | ||
commodity = 'TT' | ||
scAddress = '0xe539E0AED3C1971560517D58277f8dd9aC296281' | ||
network = 'mumbai' | ||
origin = 'https://sandbox.wert.io' | ||
break | ||
case 'prod': | ||
partnerId = '01HR4TB274GD2VNZW0VEAXNHW2' | ||
commodity = 'MANA' | ||
scAddress = '0x9D32AaC179153A991e832550d9F96441Ea27763A' | ||
network = 'polygon' | ||
origin = 'https://widget.wert.io' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables can be set as environment variables, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the variables cannot be combined and they depend only in the env you are working on, seems unnecessary to add each one separately to the config files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, you might want to use the environment variable from the envs lib, and put the stg and prod environment under the same place, what do you think?
partnerId = '01HRRQQ70YK4SP88GHM9A61P6B' | ||
commodity = 'TT' | ||
scAddress = '0xe539E0AED3C1971560517D58277f8dd9aC296281' | ||
network = 'mumbai' | ||
origin = 'https://sandbox.wert.io' | ||
break | ||
case 'prod': | ||
partnerId = '01HR4TB274GD2VNZW0VEAXNHW2' | ||
commodity = 'MANA' | ||
scAddress = '0x9D32AaC179153A991e832550d9F96441Ea27763A' | ||
network = 'polygon' | ||
origin = 'https://widget.wert.io' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, you might want to use the environment variable from the envs lib, and put the stg and prod environment under the same place, what do you think?
Feature is enabled by the
builder-publish-collections-wert
flag. The flag only shows or hides the button to "buy with card" the rest of the UI changes are not behind the flag given that they are an enhancement and align more with the provided designs.The most affected part codewise is the
handlePublishCollectionRequest
saga. which now receives apaymentMethod
param to determine if the user wants to pay with card or MANA. Paying with MANA flow is unnafected. Paying with card will use theopenFiatGatewayWidgetRequest
from decentraland-dapps.No new components were created for this feature, only some styles and elements from the already existing publish flow were updating.