Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove connected react router appearences #3117

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

meelrossi
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 5:49pm

@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9440586211

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 47.353%

Totals Coverage Status
Change from base Build 9421091342: -0.05%
Covered Lines: 5521
Relevant Lines: 10657

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9440711132

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 47.353%

Totals Coverage Status
Change from base Build 9421091342: -0.05%
Covered Lines: 5521
Relevant Lines: 10657

💛 - Coveralls

@@ -65,12 +65,6 @@ export default function CollectionsPage(props: Props) {
const timeout = useRef<NodeJS.Timeout | null>(null)
const history = useHistory()

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed beyond the scope of router right? Just to prevent the modal from showing up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess :)

@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9453099674

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 47.361%

Totals Coverage Status
Change from base Build 9451354943: -0.05%
Covered Lines: 5521
Relevant Lines: 10657

💛 - Coveralls

@meelrossi meelrossi merged commit f323180 into master Jun 10, 2024
7 checks passed
@meelrossi meelrossi deleted the feat/remove-push-sagas-4 branch June 10, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants