Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove connected react router push from components (3) #3124

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

meelrossi
Copy link
Contributor

This is part 3 of a series of PRs to completely remove connected-react-router from dapp

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 1:06pm

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9468652549

Details

  • 31 of 68 (45.59%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 47.328%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/location/selectors.ts 23 33 69.7%
src/modules/pool/selectors.ts 5 15 33.33%
src/modules/ui/dashboard/selectors.ts 2 19 10.53%
Files with Coverage Reduction New Missed Lines %
src/routing/locations.ts 2 28.57%
Totals Coverage Status
Change from base Build 9453207453: -0.03%
Covered Lines: 5515
Relevant Lines: 10650

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9483738573

Details

  • 31 of 68 (45.59%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 47.328%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/location/selectors.ts 23 33 69.7%
src/modules/pool/selectors.ts 5 15 33.33%
src/modules/ui/dashboard/selectors.ts 2 19 10.53%
Files with Coverage Reduction New Missed Lines %
src/routing/locations.ts 2 28.57%
Totals Coverage Status
Change from base Build 9483732463: -0.03%
Covered Lines: 5515
Relevant Lines: 10650

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9584955685

Details

  • 31 of 68 (45.59%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 47.328%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/location/selectors.ts 23 33 69.7%
src/modules/pool/selectors.ts 5 15 33.33%
src/modules/ui/dashboard/selectors.ts 2 19 10.53%
Files with Coverage Reduction New Missed Lines %
src/routing/locations.ts 2 28.57%
Totals Coverage Status
Change from base Build 9584642607: -0.03%
Covered Lines: 5515
Relevant Lines: 10650

💛 - Coveralls

Co-authored-by: Gabriel Díaz <git@subsme.slmail.me>
Signed-off-by: Melisa Anabella Rossi <merossi@itba.edu.ar>
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9597964218

Details

  • 31 of 68 (45.59%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 47.321%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/location/selectors.ts 23 33 69.7%
src/modules/pool/selectors.ts 5 15 33.33%
src/modules/ui/dashboard/selectors.ts 2 19 10.53%
Files with Coverage Reduction New Missed Lines %
src/routing/locations.ts 2 28.57%
Totals Coverage Status
Change from base Build 9584642607: -0.04%
Covered Lines: 5515
Relevant Lines: 10650

💛 - Coveralls

@meelrossi meelrossi merged commit 3f89e4f into master Jun 20, 2024
7 checks passed
@meelrossi meelrossi deleted the feat/remove-push-sagas-6.3 branch June 20, 2024 13:48
meelrossi added a commit that referenced this pull request Jun 20, 2024
meelrossi added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants