Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate scene thumbnail #201

Merged
merged 5 commits into from
May 15, 2023
Merged

feat: validate scene thumbnail #201

merged 5 commits into from
May 15, 2023

Conversation

marianogoldman
Copy link
Contributor

@marianogoldman marianogoldman commented May 12, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited
Loading

Test this pull request

  • The package can be tested by running 
    yarn upgrade "https://sdk-team-cdn.decentraland.org/@dcl//branch//dcl-content-validator-4.5.5-4980947396.commit-1771470.tgz"

@marianogoldman marianogoldman marked this pull request as ready for review May 15, 2023 11:44
@marianogoldman marianogoldman merged commit ba30d03 into main May 15, 2023
3 checks passed
@marianogoldman marianogoldman deleted the feat/scene-thumbnail-validation branch May 15, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleortega aleortega aleortega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate that scene thumbnail references an embedded file, not an absolute URL
2 participants
@marianogoldman @aleortega