fix: support erc721 interface standard #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eordano
requested changes
Oct 2, 2018
ERC821.md
Outdated
| @@ -75,7 +75,7 @@ Return the total amount of assets under this DAR. This method SHALL NOT throw. | |||
|
|
|||
| #### `supportsInterface(bytes8 interfaceId):bool` | |||
|
|
|||
| This method returns `true` if the `interfaceId` is a supported interface (165, corresponding to 0x01ffc9a7, or 821, corresponding to 0x959d7abb). This method SHALL NOT throw. | |||
| This method returns `true` if the `interfaceId` is a supported interface (165, corresponding to 0x01ffc9a7, or 821, corresponding to 0x7c0633c6). This method SHALL NOT throw. | |||
There was a problem hiding this comment.
@eordano We should update to that ID? our implementation is 0x7c0633c6 cause:
The regular ERC721's selector is `0x80ac58cd` but the Decentraland one is slightly different because `getApprovedAddress` is used instead of `getApproved`
Maybe we should update getApprovedAddress too
There was a problem hiding this comment.
I think just changing the docs here might do the trick?
This method returns `true` if the `interfaceId` is a supported interface (165, corresponding to 0x01ffc9a7, 821, corresponding to 0x7c0633c6, or 721 corresponding to 0x80ac58cd). This method SHALL NOT throw.
This method returns `true` if the `interfaceId` is a supported interface (165, corresponding to 0x01ffc9a7,
- or 821, corresponding to 0x7c0633c6
+ 821, corresponding to 0x7c0633c6, or 721 corresponding to 0x80ac58cd
). This method SHALL NOT throw.
eordano
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ERC721 standar interface
Close decentraland/marketplace-contracts#24