Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open re-open launcher on windows #125

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix: open re-open launcher on windows #125

merged 1 commit into from
Jan 6, 2023

Conversation

2fd
Copy link
Contributor

@2fd 2fd commented Jan 5, 2023

What does this PR change?

This PR fixes decentraland/explorer-desktop/issues/315

Re-open the launcher by clicking on the launcher icon

open-on-click.mov.mp4

Re-open the launcher using right-click menu

open-on-menu.mov.mp4

How to test the changes? (windows only)

  • build launcher
  • install the new version
  • open it
  • minimize the launcher windows

@2fd 2fd requested a review from a team January 5, 2023 14:59
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

After the CI passes:

This branch can be downloaded with the following links:

@2fd 2fd requested a review from kuruk-mm January 5, 2023 17:06
@2fd 2fd assigned 2fd and unassigned kuruk-mm Jan 5, 2023
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olavra requested to deny opening the launcher while the Desktop Client was running. The main reason, it's when you open the launcher while it's running, there is an ugly Connected label.

Anyway, this should fix the issue.

@2fd 2fd merged commit 7cabc04 into main Jan 6, 2023
@2fd 2fd deleted the fix/re-open-on-windows branch January 6, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimized launcher can't be maximized ever again
2 participants