Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avatar loading issues #377

Merged
merged 5 commits into from
Mar 26, 2024
Merged

fix: avatar loading issues #377

merged 5 commits into from
Mar 26, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Mar 26, 2024

Fix #301

  • feat: Add forceRender property
  • fix: Make name optional, some wearables fail when loading because the deserializer couldn't find the property
  • chore: move wearable vlidation to rust
  • make get_wearable_representation body_shape_id param case insensitive
  • fix: hidings not working well

wip
add DEBUG_SAVE_AVATAR_DATA for debugging purposes
@leanmendoza leanmendoza marked this pull request as ready for review March 26, 2024 16:53
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just minor reviews

godot/project.godot Outdated Show resolved Hide resolved
Co-authored-by: Mateo Miccino <mateomiccino@gmail.com>
Signed-off-by: Lean Mendoza <leandro@decentraland.org>
Signed-off-by: Lean Mendoza <leandro@decentraland.org>
@leanmendoza leanmendoza enabled auto-merge (squash) March 26, 2024 19:20
@leanmendoza leanmendoza merged commit c2febeb into main Mar 26, 2024
3 checks passed
@leanmendoza leanmendoza deleted the fix/avatar-loading-issues branch March 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar is not hidding parts of the body when equips a wearables that request it
2 participants