test: add more tests

decentraland · Apr 23, 2019 · 4a73f7a · 4a73f7a
1 parent 80c4205
commit 4a73f7a
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/test/EstateRegistry.js b/test/EstateRegistry.js
@@ -1240,13 +1240,27 @@ contract('EstateRegistry', accounts => {
     })
 
     it('reverts if not owner or approvedForAll set updateManager', async function() {
+      // Not owner
       await assertRevert(
         estate.setUpdateManager(user, operator, true, sentByAnotherUser)
       )
 
+      // Hacker
       await assertRevert(
         estate.setUpdateManager(user, operator, true, sentByHacker)
       )
+
+      // Operator
+      await estate.approve(operator, 1, sentByUser)
+      await assertRevert(
+        estate.setUpdateManager(user, operator, true, sentByOperator)
+      )
+
+      // Update Operator
+      await estate.setUpdateOperator(1, anotherUser, sentByUser)
+      await assertRevert(
+        estate.setUpdateManager(user, operator, true, sentByAnotherUser)
+      )
     })
 
     it('reverts when updateManager trying to transfer', async function() {

diff --git a/test/LANDRegistry.js b/test/LANDRegistry.js
@@ -1048,13 +1048,27 @@ contract('LANDRegistry', accounts => {
     })
 
     it('reverts if not owner or approvedForAll set updateManager', async function() {
+      // Not owner
       await assertRevert(
         land.setUpdateManager(user, operator, true, sentByAnotherUser)
       )
 
+      // Hacker
       await assertRevert(
         land.setUpdateManager(user, operator, true, sentByHacker)
       )
+
+      // Operator
+      await land.approve(operator, 1, sentByUser)
+      await assertRevert(
+        land.setUpdateManager(user, operator, true, sentByOperator)
+      )
+
+      // Update Operator
+      await land.setUpdateOperator(1, anotherUser, sentByUser)
+      await assertRevert(
+        land.setUpdateManager(user, operator, true, sentByAnotherUser)
+      )
     })
 
     it('reverts when updateManager trying to transfer', async function() {