fix: Set optional authentication for get picks by list id

decentraland · Jun 15, 2023 · c0f6e53 · c0f6e53
1 parent 474371b
commit c0f6e53
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 38 deletions.
diff --git a/src/controllers/handlers/lists-handlers.ts b/src/controllers/handlers/lists-handlers.ts
@@ -30,16 +30,6 @@ export async function getPicksByListIdHandler(
   } = context
   const userAddress: string | undefined = verification?.auth.toLowerCase()
 
-  if (!userAddress) {
-    return {
-      status: StatusCode.UNAUTHORIZED,
-      body: {
-        ok: false,
-        message: 'Unauthorized'
-      }
-    }
-  }
-
   const { limit, offset } = getPaginationParams(url.searchParams)
   const picksByListIdResult = await lists.getPicksByListId(params.id, {
     userAddress,

diff --git a/src/controllers/routes.ts b/src/controllers/routes.ts
@@ -33,7 +33,7 @@ export function setupRouter({ components: { schemaValidator } }: GlobalContext):
   router.get(
     '/v1/lists/:id/picks',
     authorizationMiddleware.wellKnownComponents({
-      optional: false,
+      optional: true,
       expiration: FIVE_MINUTES
     }),
     getPicksByListIdHandler

diff --git a/src/ports/lists/types.ts b/src/ports/lists/types.ts
@@ -15,10 +15,11 @@ export interface IListsComponents {
 }
 
 export type GetAuthenticatedAndPaginatedParameters = {
-  userAddress: string
+  userAddress?: string
 } & PaginationParameters
 
-export type GetListsParameters = GetAuthenticatedAndPaginatedParameters & {
+export type GetListsParameters = PaginationParameters & {
+  userAddress: string
   sortBy?: ListSortBy
   sortDirection?: ListSortDirection
   itemId?: string | null

diff --git a/test/unit/lists-handler.spec.ts b/test/unit/lists-handler.spec.ts
@@ -50,31 +50,6 @@ describe('when getting the picks of a list', () => {
     params = { id: listId }
   })
 
-  describe('and the request is not authenticated', () => {
-    beforeEach(() => {
-      verification = undefined
-    })
-
-    it('should return an unauthorized response', () => {
-      return expect(
-        getPicksByListIdHandler({
-          url,
-          components,
-          verification,
-          request,
-          params
-        })
-      ).resolves.toEqual({
-        status: StatusCode.UNAUTHORIZED,
-        body: {
-          ok: false,
-          message: 'Unauthorized',
-          data: undefined
-        }
-      })
-    })
-  })
-
   describe('and the process to get the picks fails', () => {
     let error: Error