Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add search by utility #108

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

LautaroPetaccio
Copy link
Contributor

This PR makes the item's utility and the utility keyword searchable.
It does so by:

  • Altering the builder's server table to include the utility column.
  • Creating a materialized view with the builder's server's utilities.
  • Creating a new query to search items by utility or by the item having utility (which is underweighted to not surpass the search by name or tag).
  • Unifying both search queries (the names and tag ones with the utility one) and returning their unique ids.

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9101107590

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 145 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 55.003%

Files with Coverage Reduction New Missed Lines %
src/ports/catalog/component.ts 26 12.2%
src/ports/catalog/queries.ts 119 16.4%
Totals Coverage Status
Change from base Build 9003451499: -0.4%
Covered Lines: 798
Relevant Lines: 1331

💛 - Coveralls

Copy link
Collaborator

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! 🚀 🚀🚀🚀

@LautaroPetaccio LautaroPetaccio merged commit 7ce0f72 into main May 15, 2024
1 check passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-search-by-utility branch May 15, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants