Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add emotes missing where query #84

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: Add emotes missing where query #84

merged 2 commits into from
Feb 13, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Feb 13, 2024

This PR adds the missing Emote props: hasGeometry and hasSound to the catalog query.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7888051507

Details

  • -3 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 35.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ports/catalog/utils.ts 0 1 0.0%
src/ports/catalog/queries.ts 2 4 50.0%
Totals Coverage Status
Change from base Build 7886906420: -0.09%
Covered Lines: 281
Relevant Lines: 605
💛 - Coveralls

juanmahidalgo
juanmahidalgo approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@juanmahidalgo juanmahidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@cyaiox cyaiox merged commit f5f8800 into main Feb 13, 2024
1 check passed
@cyaiox cyaiox deleted the fix/add-emotes-missing-where-query branch February 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmahidalgo juanmahidalgo juanmahidalgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyaiox @coveralls @juanmahidalgo