fix: Add tracking to the UserInformation component #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix/add-tracking-to-user-information
Pull Request Test Coverage Report for Build 6508900701
💛 - Coveralls |
braianj
approved these changes
Oct 13, 2023
Comment on lines
+357
to
+358
| const from = numeric(offset || 0, { min: 0 }) ?? 0 | ||
| const to = numeric(from + (limit || 100), { min: 0, max: 100 }) ?? 100 |
There was a problem hiding this comment.
do we need this? we are already sending 0 or 100 to the function
There was a problem hiding this comment.
The function returns number | null, making us provide a default number.
Comment on lines
+64
to
+65
| offset: numeric(query.offset, { min: 0 }) ?? 0, | ||
| limit: numeric(query.limit, { min: 0, max: 100 }) ?? 100, |
There was a problem hiding this comment.
Same as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
decentraland-gatsbydependency to add tracking to it.