chore: Complete README #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
Co-authored-by: Nicolas Santangelo <santangelonicolas@gmail.com>
nachomazzara
reviewed
Aug 3, 2022
| - rentalDays: The amount of days I want to rent this LAND. It has to be in range between the min and max days of the index I choose or else it fails. | ||
| - fingerprint: In the case of an Estate, this indicates the fingerprint it should have when renting it to me. This prevents the owner to front run me and remove LAND from it before renting it. | ||
|
|
||
| If everything is correct, MANA equivalent to the pricePerDay index I've selected, times the rentalDays I provided will be transfered from my address to the lessor (and a fee to the DAO) and the provided operator will start being able to deploy scenes to that LAND. |
There was a problem hiding this comment.
fee to the FeeCollector, the DAO is an agent that may change.
nachomazzara
reviewed
Aug 3, 2022
|
|
||
| There are various ways of signing these conditions. One of them can be achieved by using ethers as seen in the [./test/utlils/rentals.ts](https://github.com/decentraland/rentals-contract/blob/main/test/utils/rentals.ts#L81) utility file. | ||
|
|
||
| Once both the signature and the listings conditions are ready, I, or whichever off-chain system handling this, can store them to make them |
There was a problem hiding this comment.
the offer conditions?
nachomazzara
reviewed
Aug 3, 2022
|
|
||
| - offer: [Offer](#offer-struct) containing the conditions and the signature of the offer. | ||
|
|
||
| 2 - Sending the LAND to the Rentals cotract via LAND's `safeTransferFrom` function |
There was a problem hiding this comment.
cotract typo. => Contract
nachomazzara
reviewed
Aug 3, 2022
|
|
||
| ## Extending a rental | ||
|
|
||
| BEFORE a rental is over, a new listing or offer for the LAND can be accepted as long as the lessor and tenant in said offer/listing are the same. |
There was a problem hiding this comment.
Can we explain how to do that by using the target parameter in the Listing struct?
nachomazzara
reviewed
Aug 3, 2022
|
|
||
| The asset nonce is always bumped for both the lessor and the tenant once a rent is initialized to prevent any other listings or offers with the current nonce to be usable. This is a safety meassure to ensure that the least amount of usable signatures are available off-chain in the case of a signature storage breach. | ||
|
|
||
| In the case of the signer nonce, imagine that I signed a lot of listings or offers with the current nonce but for some reason I don't trust the way they are stored, I could just call the asset nonce bump to invalidate them all at once. |
There was a problem hiding this comment.
What is the case of the contract nonce? Should we need to add it too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.