Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added profile pooling #993

Merged
merged 5 commits into from
Jun 18, 2024
Merged

feat: added profile pooling #993

merged 5 commits into from
Jun 18, 2024

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented May 7, 2024

What does this PR change?

Implements profile pooling. Profiles will always be created through a pool and the disposal will release the instance.

TODO: make proper release of peers that are no longer around the player

How to test the changes?

  1. Launch the explorer
  2. Check this report still working: [QA] Changes in wearables not propagated (maybe the same with emotes) #792
  3. Check that everytime you change wearables or emotes your avatar is updated in-world
  4. Check other peers avatars, they should be propagated as expected
  5. Logout->login with new account and/or same account. Observe your avatar is properly updated

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@lorux0 lorux0 linked an issue May 7, 2024 that may be closed by this pull request
@lorux0 lorux0 marked this pull request as ready for review June 10, 2024 14:35
Copy link

github-actions bot commented Jun 10, 2024

badge

Windows build successfull! You can find a link to the downloadable artifact below.

Name Link
Commit 13d7d97
Logs https://github.com/decentraland/unity-explorer/actions/runs/9566887222
Download https://github.com/decentraland/unity-explorer/suites/25038985120/artifacts/1613286168
Built on 2024-06-18T14:50:56Z

Copy link
Contributor

@anicalbano anicalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Conflicts:
#	Explorer/Assets/DCL/Multiplayer/SDK/Systems/GlobalWorld/PlayerProfileDataPropagationSystem.cs
@lorux0 lorux0 enabled auto-merge (squash) June 18, 2024 14:27
@lorux0 lorux0 merged commit a7433bc into main Jun 18, 2024
5 of 6 checks passed
@lorux0 lorux0 deleted the fix/profile-pooling branch June 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiles are not reused
3 participants