add support for multiple chain's on nftShape & openNftShapeDialog #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 7SDK 6More |
gonpombo8
force-pushed
the
feat/nft-shape-multiple-chain
branch
from
4d1d0a0
to
b34a227
Compare
Ludmilafantaniella
approved these changes
May 14, 2024
There was a problem hiding this comment.
Verified on Desktop and Browser and approved by QA.
Slack thread for more details.
6196.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fix NFTShapes not being rendered on SDK7
Add support for every chain that OpenSea supports.
Increase the limit of the MAX_IMAGE_SIZE to 6Mb.
If some NFT is not being rendered, maybe its because of the image being too big. Ping me and I'll check it out
How to test the changes?
Go to any SDK6 & SDK7 scene on genesis plaza and verify that the NFTShapes & NFT Modals works as expected
https://decentraland.org/play/?realm=boedo.dcl.eth Has two NFTShapes, one from polygon and the other one from Arbitrum. They should be rendered on this branch.
Copilot summary
copilot:summary