feat: added zoom scale param #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cazala
commented
Nov 8, 2023
| @@ -145,6 +145,7 @@ export async function createScene( | |||
| // Setup Camera | |||
| const camera = new ArcRotateCamera('camera', 0, 0, 0, new Vector3(0, 0, 0), root) | |||
| camera.position = new Vector3(config.cameraX, config.cameraY, config.cameraZ) | |||
| camera.minZ = 0.1 | |||
There was a problem hiding this comment.
This fixes the clipping issue that prevented us from having higher zoom levels before
cyaiox
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to increase the zoom via de
zoomScaleproperty. We were limiting the max zoom to a low value because it started clipping beyond a certain zoom level, but it was because of thecamera.minZvalue being too high, i set it to0.1and now we can put the camera really close to the avatar without clipping.We need to be able to put the camera very close to the avatar face to generate the face snapshots for the profile-images research.
I didn't just increase the
MAX_ZOOMvalue because that would change the way the zoom property behaves, and I didn't want to break anything in production. So instead I added thiszoomScalewhich is 1 by default, but if necessary it can be used to make the zoom go beyond theMAX_ZOOMlevel.