Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add did-jwt-vc tests #44

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

kimdhamilton
Copy link
Contributor

Added did-jwt-vc tests, focusing only on signing and ed25519 to start with. Skeleton of the rest is there.

Specifically, signing tests for the following pass:

  • credential-1--key-0-ed25519.vc-jwt.json
  • credential-2--key-0-ed25519.vc-jwt.json
  • credential-3--key-0-ed25519.vc-jwt.json
  • presentation-0--key-0-ed25519.vp-jwt.json
  • presentation-1--key-0-ed25519.vp-jwt.json

Note that there is a lot of duplication with other js implementations (bin and cli). Addressing that seemed out of scope.

As for implementing the rest -- this test suite is a little onerous so I had to timebox the work. But I included the framework so that it give subsequent people a good head start:

  • Support for additional signers should be easy for someone with the JWK mappings in active recall.
  • Verification should be straightforward if someone can add a did:example resolver

@bumblefudge
Copy link

Addresses #39

@clehner
Copy link
Collaborator

clehner commented Mar 3, 2022

Nice!
I see the following results, showing some successful Ed25519 VCs and VPs:
2022-03-03-092736_762x931_scrot

@OR13
Copy link
Collaborator

OR13 commented Mar 3, 2022

@clehner @peacekeeper I wonder if we can figure out how to consistently handle the "no support" side of this... so that it does not look like an implementation is failing when they don't support the key type or algorithm.

Co-authored-by: Charles E. Lehner <cel@celehner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants