Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use EdDSA as the 'alg' header for Ed25519 signatures #131

Merged
merged 1 commit into from Oct 1, 2020

Conversation

alexjg
Copy link
Contributor

@alexjg alexjg commented Sep 11, 2020

Fixes #130

I've left the old algorithm parameters in for backwards compatibility. I don't know if this is desirable?

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@mirceanis mirceanis merged commit 2736ee7 into decentralized-identity:master Oct 1, 2020
uport-automation-bot pushed a commit that referenced this pull request Oct 1, 2020
## [4.6.1](4.6.0...4.6.1) (2020-10-01)

### Bug Fixes

* use EdDSA as the 'alg' header for Ed25519 signatures ([#131](#131)) ([2736ee7](2736ee7))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 4.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect "alg" header for Ed25519 signatures
3 participants