Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why owner instead of controller? #54

Closed
aceshim opened this issue Aug 13, 2020 · 2 comments
Closed

Why owner instead of controller? #54

aceshim opened this issue Aug 13, 2020 · 2 comments
Labels
spec more parties need to agree

Comments

@aceshim
Copy link
Contributor

aceshim commented Aug 13, 2020

Is there a specific reason why you call 'controller' property 'owner' in pubkey?
To follow w3c DID spec, I think we should change it to 'controller'
@mirceanis
Copy link
Member

It is a legacy, not intentionally kept like that, and it should be updated.

This resolver was built before the W3C spec was a thing and was not updated for developer bandwidth reasons and because the controller/owner property of keys was not used in any project.

Feel free to submit a PR, especially if you are using this directly.

@aceshim aceshim mentioned this issue Aug 13, 2020
Merged
uport-automation-bot pushed a commit that referenced this issue Aug 14, 2020
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
ebb6262 
# [2.1.0](2.0.1...2.1.0) (2020-08-14)

### Features

* rename PublicKey attribute 'owner' to 'controller' ([#55](#55)) ([850e5a5](850e5a5)), closes [#54](#54)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uport-automation-bot uport-automation-bot added the spec more parties need to agree label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec more parties need to agree
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mirceanis @aceshim @uport-automation-bot