Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Queue as a Transport option #49

Closed

Conversation

TelegramSam
Copy link
Collaborator

Discussion that led to this addition: hyperledger/aries-rfcs#405
Signed-off-by: Sam Curren telegramsam@gmail.com

Signed-off-by: Sam Curren <telegramsam@gmail.com>
Copy link
Contributor

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the right place for this. Seem comment below.

@@ -17,3 +18,11 @@ TODO: Include details of the websocket message to define a standard usage.
TODO:
* Quic
* Transport binding

#### Queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit odd to describe it as a transport. It seems like a pattern in how transports are used rather than an actual transport method itself. I agree that this needs to be described within this spec because it's a key function of routing to mobile devices, but let me see if there's a better place for this to live to prevent confusion about what the "transport layer" actually is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it doesn't it one aspect of transports (because it isn't an actual transport.) This section is also used to understand how to process the various endpoint types in a DIDComm service entry of a DID Document. In that aspect, it fits right in.

This is on the list of conversation topics for today's call.

@TelegramSam
Copy link
Collaborator Author

I'm going to pull close this PR at this point and revisit it later, after routing and some of the other issues have been more thoroughly discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants