fix(build): transpile for commonjs, use wrapper for esm #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [6.2.4-alpha.1](6.2.3...6.2.4-alpha.1) (2022-10-13) ### Bug Fixes * create alpha release ([1d5d5f2](1d5d5f2))
BREAKING CHANGE: ESM is only supported through a wrapper
# [7.0.0-alpha.1](6.2.4-alpha.1...7.0.0-alpha.1) (2022-10-13) ### Bug Fixes * add esm wrapper instead of double transpile ([d2bbeaf](d2bbeaf)) ### BREAKING CHANGES * ESM is only supported through a wrapper
# [7.0.0-alpha.2](7.0.0-alpha.1...7.0.0-alpha.2) (2022-10-14) ### Bug Fixes * **build:** build commonjs and also expose esm wrapper ([522c199](522c199))
# [7.0.0-alpha.3](7.0.0-alpha.2...7.0.0-alpha.3) (2022-10-14) ### Bug Fixes * **build:** use commonjs module in tsconfig ([e66d054](e66d054)) * **ci:** run tests on a matrix of node versions ([3825ac0](3825ac0))
uport-automation-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
# [7.0.0](6.2.3...7.0.0) (2022-10-17) ### Bug Fixes * **build:** transpile for commonjs, use wrapper for esm ([#170](#170)) ([5eba679](5eba679)) ### BREAKING CHANGES * **build:** previous versions (<7.0.0) would be transpiled twice by microbundle, but this seems to be [anti-pattern](https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1) Please raise an issue on https://github.com/decentralized-identity/ethr-did-resolver if this change is incompatible with your tech stack and there are no workarounds.
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: previous versions (<7.0.0) would be transpiled twice by microbundle, but this seems to be an anti-pattern
I suspect that for ESM projects, this might reduce the effectiveness of tree-shaking.