Replace "schema" with more explicit "type" approach #258
Conversation
These two constraints will be the most used of all the constraints so they should be first
| "const": "https://yourwatchful.gov/drivers-license-schema.json" | ||
| } | ||
| } | ||
| ], | ||
| "fields": [ | ||
| { | ||
| "path": ["$.expirationDate"], | ||
| "filter": { | ||
| "type": "string", | ||
| "format": "date-time", |
There was a problem hiding this comment.
notably, the newest version of json schema removes the format property. this may be considered in PEv2
There was a problem hiding this comment.
Interesting could you send me a link to that? I hadn't heard that format was going away, what is replacing it?
| "path": ["$.credentialSchema.id", "$.vc.credentialSchema.id"], | ||
| "filter": { | ||
| "type": "string", | ||
| "const": "hub://did:foo:123/Collections/schema.us.gov/passport.json" |
There was a problem hiding this comment.
is there an example that shows OR logic?
| { | ||
| "path": ["$.credentialSchema", "$.vc.credentialSchema"], | ||
| "filter": { | ||
| "allOf": [ |
spec/spec.md
Outdated
| - The _constraints objext_ ****MAY**** contain a `types` property. If present it's value ****MUST**** be an array of objects as composed as follows: | ||
| - The _types object_ ****MUST**** contains a `path` property. The value of this property has the same requirements as the _fields object_'s `path` property | ||
| - The _types object_ ****MUST**** contain a `filter` property. The value of this property has the same requirements as the _fields object_'s `filter` property | ||
| - The _types object_ ****MAY**** contain an `id` property. The value of this property has the same requirements as the _fields object_'s `id` property |
There was a problem hiding this comment.
The reason the fields object has an id property is because it is referred to elsewhere in the spec. Is there a similar requirement here?
There was a problem hiding this comment.
Ah yeah that makes sense why id is on fields, I don't see a similar constraint for the types. Will remove
| - The _types object_ ****MUST**** contains a `path` property. The value of this property has the same requirements as the _fields object_'s `path` property | ||
| - The _types object_ ****MUST**** contain a `filter` property. The value of this property has the same requirements as the _fields object_'s `filter` property | ||
| - The _types object_ ****MAY**** contain an `id` property. The value of this property has the same requirements as the _fields object_'s `id` property | ||
| - The _types object_ ****MAY**** contain an `purpose` property. The value of this property has the same requirements as the _fields object_'s `purpose` property |
There was a problem hiding this comment.
I also wonder if the purpose property is necessary here.
There was a problem hiding this comment.
I do think the purpose field is important, to allow wallets to have a human readable sentence for why the requester is specifying this type
| "constraints": { | ||
| "limit_disclosure": "required", | ||
| "types": [ |
There was a problem hiding this comment.
This could also be done with multiple "type objects"in the types array
JaceHensley
dismissed stale reviews from brentzundel and kimdhamilton
via
43a9b43
Closes #256
Closes #213
Closes #250
Closes #217