Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow only canonical encoded DID suffix to pass hash check #873

Closed
thehenrytsai opened this issue Oct 2, 2020 · 1 comment
Closed

Allow only canonical encoded DID suffix to pass hash check #873

thehenrytsai opened this issue Oct 2, 2020 · 1 comment
Projects
Reference implementation

Comments

@thehenrytsai
Copy link
Collaborator

DID suffix EiDDidVHVekuMIYV3HI5nfp8KP6s3_W44Pd-MO5b-XK5iQ and EiDDidVHVekuMIYV3HI5nfp8KP6s3_W44Pd-MO5b-XK5iR both will decode into the same buffer which results in both being valid for the given valid suffix data in current implementation.

Tighten up the check so only canonical encoded string will pass the check.
thehenrytsai added a commit that referenced this issue Oct 2, 2020
@thehenrytsai
fix(ref-imp): #873 - Allowed only canonically encoded DID suffix to p…
7b3be64 
…ass hash check.
@thehenrytsai thehenrytsai added this to 2020 October in Reference implementation Oct 2, 2020
thehenrytsai added a commit that referenced this issue Oct 6, 2020
@thehenrytsai
fix(ref-imp): #873 - Allowed only canonically encoded DID suffix to p…
a1fbdbf 
…ass hash check
@thehenrytsai
Copy link
Collaborator Author

Done.

Reference implementation automation moved this from 2020 October to Done Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Reference implementation
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehenrytsai