Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serviceEndpoint string check should use a proper URI library #898

Closed
thehenrytsai opened this issue Oct 24, 2020 · 1 comment
Closed

serviceEndpoint string check should use a proper URI library #898

thehenrytsai opened this issue Oct 24, 2020 · 1 comment
Labels
bug Something isn't working
Projects
Reference implementation

Comments

@thehenrytsai
Copy link
Collaborator

The current use of URL lib to perform the serviceEndpoint string check is not compliant to the Sidetree spec.
Use uri-js npm pacakge's URI.parse() to do the job.
@thehenrytsai thehenrytsai added bug Something isn't working beta labels Oct 24, 2020
@thehenrytsai thehenrytsai added this to 2020 November in Reference implementation Oct 29, 2020
thehenrytsai added a commit that referenced this issue Oct 30, 2020
@thehenrytsai
fix(ref-imp): #898 - Used a URI library for URI validation.
ac48bf6
thehenrytsai added a commit that referenced this issue Oct 30, 2020
@thehenrytsai
fix(ref-imp): #898 - Used a URI library for URI validation
bdeeb5f
@thehenrytsai
Copy link
Collaborator Author

Done.

Reference implementation automation moved this from 2020 November to Done Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Reference implementation
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehenrytsai