Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to decide on what hash algorithm to use when hashing suffix data #965

Closed
thehenrytsai opened this issue Dec 5, 2020 · 6 comments
Closed
Labels
enhancement A change to existing implementation v-next

Comments

@thehenrytsai
Copy link
Collaborator

Need to decide on what hash algorithm to use when hashing suffix data when multiple hash algorithms are supported, the case overlooked in current implementation is that a long-form DID can be registered any time in the future.

@thehenrytsai thehenrytsai added bug Something isn't working beta labels Dec 5, 2020
@csuwildcat
Copy link
Member

Question: aren't there already values within the suffix data that indicate this, and if not, should we consider just adding a version string to the create suffix portion that is required, to provide you with specific instructions that are unambiguous?

Ironically, this may be a great example of why a DID Method should have the ability to shift a user's DID representation to a new form using canonical/equivalent ID references.

@sandrask
Copy link
Collaborator

@thehenrytsai @csuwildcat Should we use the multihash code that is used for recoveryCommitment (part of suffix data)?

@OR13
Copy link
Contributor

OR13 commented Dec 15, 2020

prefer to have the behavior fully defined in the spec, with RECOMMENDED text.

@thehenrytsai thehenrytsai added enhancement A change to existing implementation and removed bug Something isn't working labels Dec 15, 2020
@sandrask
Copy link
Collaborator

@thehenrytsai @csuwildcat @csuwildcat @troyronda According to spec all hashes have to be calculated using the same currently supported multi-hashing algorithm (https://identity.foundation/sidetree/spec/#hashing-process). Does this mean that you should reject create request with hashes that are calculated with different algorithm? For scenario that we discussed today (long-form DID that may get anchored year later) this issue may not be limited to generating unique suffix only. In addition, all hashes in one operation request should be generated with same multihashing algorithm (except for reveal value).

@thehenrytsai
Copy link
Collaborator Author

Having a version property was discussed as a viable approach, absence of such a property can imply version 1.

@thehenrytsai thehenrytsai added v-next and removed beta labels Dec 30, 2020
@decentralgabe
Copy link
Member

Handled in spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change to existing implementation v-next
Projects
None yet
Development

No branches or pull requests

5 participants