Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare directory structure for V1 #38

Closed
wants to merge 7 commits into from
Closed

Prepare directory structure for V1 #38

wants to merge 7 commits into from

Conversation

decentralgabe
Copy link
Member

No description provided.

@dtmcg
Copy link

dtmcg commented Nov 30, 2022

do you want to keep a working copy under spec/spec.md?

@decentralgabe
Copy link
Member Author

do you want to keep a working copy under spec/spec.md?

don't think so - can just create a new version folder for changes

@bumblefudge
Copy link

Some thoughts, each of which I'd recommend converting to new issues for addressing post v1 unless they have easy answers or can be addressed by quick edits:

  1. why author and not, say, controller?
  2. I took a kind of contrarian, sassy stab at the "todo" to define trust topics, please iterate if it's too sassy or judgmental. Spec is a little cryptic without a little more explanation of its use-case and mental model!
  3. The Topic Registry TODO I think should be done before v1. Since topics are defined as URIs of schemas, you could just point to schema-directory or something equivalent at, say, TOIP?
    3B. Sidenote: the schema directory doesn't really look like the other DIF registries, maybe we can give that group a nudge to make something more... presentable? It feels like another case of the "v1 can't be cut if it depends on a v0 spec or registry" problem that has plagued this WG since time immemorial 😉

Editorial pass + 1todo
29e0d5e 
Signed-off-by: bumblefudge <jcaballero@centre.io>
@bumblefudge
Copy link

also note
image

bumblefudge
bumblefudge requested changes Dec 1, 2022
View reviewed changes
spec/v1/spec.md Outdated

## Appendix

### Topic Registry

::: todo Topic Registry
Create a place for topics to be registered.
The [schema directory](https://github.com/decentralized-identity/schema-directory/blob/main/content/schemas.md) seems like one place where schemas are registered, but I would also recommend adding a definition of what you mean by "registry" and ideally more than one example. __chair
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be addressed before v1; see PR discussion for more detail

@decentralgabe decentralgabe mentioned this pull request Dec 2, 2022
Open
@decentralgabe
Copy link
Member Author

Thanks @bumblefudge for the review.

I opened up decentralized-identity/schema-directory#5 on the Schema Directory repo.

I've added spec text around Trust Topics that I hope addresses your feedback.

I wonder about the semantic different between author and controller. I believe author implies controller -- or at least that is my intention, though I'm not sure the inverse is true. The intent was to establish who created the document.

Got rid of those TODOs. Let me know what you think.

decentralgabe
decentralgabe commented Dec 2, 2022
View reviewed changes
spec/v1/spec.md
@@ -527,8 +522,14 @@ There may be different motivations for interacting with [[ref:Trust Establishmen

### Topic Registry

::: todo Topic Registry
Create a place for topics to be registered.
As per the section on [Publication & Discovery](#publication-discovery) there are a number of possibilities for hosting [[ref:Trust Establishment Documents]]. A related concept is defining a set of well-known [[ref:Topics]] that can find utility across an ecosystem of trust. One such option in housing these well-defined [[ref:Topics]] is a _Topic Registry_. Topic Registries can be as simple as [GitHub repositories](https://github.com/) that host a collection of topics or a website in a similar fashion to [Schema.org](https://schema.org/).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csuwildcat let me know what you think about this section, specifically on the accuracy of the DWN text

decentralgabe
decentralgabe commented Dec 2, 2022
View reviewed changes
spec/v1/spec.md

Another project at DIF, [Decentralized Web Nodes](https://identity.foundation/decentralized-web-node/spec/), also provide the ability to host and address multiple types of data. Taking advantage of the [Collections interface](https://identity.foundation/decentralized-web-node/spec/#collections) it is possible to create a _Trust Topic Collection_ that is exposed via [Feature Detection](https://identity.foundation/decentralized-web-node/spec/#feature-detection), and given a public read [permission](https://identity.foundation/decentralized-web-node/spec/#permissions). This would allow anyone to interrogate a DWN, or network of DWNs, as to whether they have a Trust Topic Registry, and next, which Trust Topics they have access to.

::: todo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TelegramSam could use your magic here

@frankhinek frankhinek closed this Mar 13, 2023
@frankhinek frankhinek deleted the v1 branch March 13, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumblefudge bumblefudge bumblefudge requested changes

@mikekebert mikekebert Awaiting requested review from mikekebert mikekebert is a code owner

@TelegramSam TelegramSam Awaiting requested review from TelegramSam TelegramSam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@decentralgabe @dtmcg @bumblefudge @frankhinek