Update agent.yml with relative imports and cors fix #31
Conversation
There was a problem hiding this comment.
Looks great, thanks for doing this! And sorry we hadn't updated this earlier. I'm not sure when this broke as it was working after the Veramo v5 update.
Will wait to approve & merge until @mirceanis takes a look
| @@ -92,7 +92,7 @@ server: | |||
| $ref: /constants/port | |||
| use: | |||
| # CORS | |||
| - - $require: 'cors' | |||
| - - $require: 'cors?t=function#default' | |||
agent.yml
Outdated
| @@ -221,7 +221,7 @@ keyManager: | |||
| - $ref: /constants/secretKey | |||
| # __TEMPLATE__: you can install your own Key Management System implementation too | |||
| my: | |||
| $require: ./build#MyKeyManagementSystem | |||
| $require: ./build/key-manager/my-key-management-system.js#MyKeyManagementSystem | |||
There was a problem hiding this comment.
might be cleaner to replace this with:
./build/index.js#MyKeyManagementSystem
There was a problem hiding this comment.
Sure - will test it first to validate that works.
Makes me think that ./build should have worked though... probs just some stupid ESM thingy though
agent.yml
Outdated
| @@ -235,7 +235,7 @@ didManager: | |||
| providers: | |||
| # __TEMPLATE__: you can install your customized DID provider like so | |||
| did:my: | |||
| $require: ./build#MyIdentifierProvider | |||
| $require: ./build/did-manager/my-identifier-provider.js#MyIdentifierProvider | |||
agent.yml
Outdated
| @@ -279,4 +279,4 @@ agent: | |||
| $args: | |||
| - $ref: /dbConnection | |||
| # __TEMPLATE__: install your plugin on the `@veramo/cli` agent | |||
| - $require: ./build#MyAgentPlugin | |||
| - $require: ./build/agent-plugin/my-plugin.js#MyAgentPlugin | |||
|
also could you update the PR comment to include "Fixes #28" ? |
Done. Will address the other recommendations tomorrow - getting late over here in UK |
|
@nickreynolds updates made |
|
looks good, going to merge. tests are failing due to goerli deprecation, I can fix that in a separate PR though (tested with sepolia on my end and they pass) |
|
@nickreynolds cheers for checking - was confused as to while failing! But yeah, I remember the Goerli deps now... PS. I am getting this error on window OS: |
ref issue: #28