Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(url-handler): allow for URL redirects (#362) #366

Merged
merged 4 commits into from
Feb 4, 2021
Merged

feat(url-handler): allow for URL redirects (#362) #366

merged 4 commits into from
Feb 4, 2021

Conversation

rkreutzer
Copy link
Contributor

I couldn't find a way for fetch mocks to return the redirected URL, so I didn't add a test.

mirceanis
mirceanis approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I added a couple of tests that exercise the new code and removed some un-necessary package-lock.json files.

Thank you for your contribution!

@mirceanis mirceanis merged commit 92a86d6 into decentralized-identity:next Feb 4, 2021
@mirceanis mirceanis mentioned this pull request Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rkreutzer @mirceanis