Fix typo in remove admin event subscriber (#12543)

* Fix delete admin event * Fix spec namespace
decidim · Feb 29, 2024 · f890380 · f890380
1 parent f403be0
commit f890380
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/decidim-proposals/lib/decidim/proposals/engine.rb b/decidim-proposals/lib/decidim/proposals/engine.rb
@@ -113,8 +113,8 @@ class Engine < ::Rails::Engine
       end
 
       initializer "decidim_proposals.remove_space_admins" do
-        ActiveSupport::Notifications.subscribe("decidim.admin.participatorty_space.destroy_admin:after") do |_event_name, klass, id|
-          Decidim::Proposals::ValuationAssignment.where(valuator_role_type: klass, valuator_role_id: id).destroy_all
+        ActiveSupport::Notifications.subscribe("decidim.admin.participatory_space.destroy_admin:after") do |_event_name, data|
+          Decidim::Proposals::ValuationAssignment.where(valuator_role_type: data.fetch(:class_name), valuator_role_id: data.fetch(:role)).destroy_all
         end
       end
 

diff --git a/decidim-proposals/spec/lib/decidim/proposals/engine_spec.rb b/decidim-proposals/spec/lib/decidim/proposals/engine_spec.rb
@@ -17,7 +17,7 @@
 
       it "removes the record" do
         expect do
-          ActiveSupport::Notifications.publish("decidim.admin.participatorty_space.destroy_admin:after", valuator_role.class.name, valuator_role.id)
+          ActiveSupport::Notifications.publish("decidim.admin.participatory_space.destroy_admin:after", class_name: valuator_role.class.name, role: valuator_role.id)
         end.to change(Decidim::Proposals::ValuationAssignment, :count).by(-1)
       end
     end
@@ -29,7 +29,7 @@
 
       it "removes the record" do
         expect do
-          ActiveSupport::Notifications.publish("decidim.admin.participatorty_space.destroy_admin:after", valuator_role.class.name, valuator_role.id)
+          ActiveSupport::Notifications.publish("decidim.admin.participatory_space.destroy_admin:after", class_name: valuator_role.class.name, role: valuator_role.id)
         end.to change(Decidim::Proposals::ValuationAssignment, :count).by(-1)
       end
     end
@@ -41,7 +41,7 @@
 
       it "removes the record" do
         expect do
-          ActiveSupport::Notifications.publish("decidim.admin.participatorty_space.destroy_admin:after", valuator_role.class.name, valuator_role.id)
+          ActiveSupport::Notifications.publish("decidim.admin.participatory_space.destroy_admin:after", class_name: valuator_role.class.name, role: valuator_role.id)
         end.to change(Decidim::Proposals::ValuationAssignment, :count).by(-1)
       end
     end