You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am currently looking at the way Decidim is being built and I have found some items that i think we can improve.
1. Active Record Concerns
There are some modules in in the decidim-core library, that are being used in the ActiveRecord models, and i think it may have more sense to keep them in a models namespace.
Decidim::Amendable
Decidim::Authorable
Decidim::Coauthorable
Decidim::Endorsable
Decidim::FilterableResource
Decidim::Followable
Decidim::HasArea
Decidim::HasAttachmentCollections
Decidim::HasAttachments
Decidim::HasCategory
Decidim::HasComponent
etc
Ex: Decidim::Amendable, may become Decidim::Model::Amendable, and it would be moved from decidim-core/lib/decidim to decidim-core/lib/decidim/model
2. Manifests
Maybe all the classess that end with "manifest" may have their own namespace:
Decidim::ComponentManifest may become Decidim::Manifests::Component
Decidim::ContentBlockManifest may become ``Decidim::Manifests::ContentBlock`
MetricManifest
MetricOperationManifest
NotificationSettingManifest
ParticipatorySpaceContextManifest
ParticipatorySpaceManifest
ReminderManifest
3. ActionController Modules
Following the previous point, it would make sense to have a Controller namespace, that may include :
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I am currently looking at the way Decidim is being built and I have found some items that i think we can improve.
1. Active Record Concerns
There are some modules in in the decidim-core library, that are being used in the ActiveRecord models, and i think it may have more sense to keep them in a models namespace.
Ex:
Decidim::Amendable
, may becomeDecidim::Model::Amendable
, and it would be moved from decidim-core/lib/decidim to decidim-core/lib/decidim/model2. Manifests
Maybe all the classess that end with "manifest" may have their own namespace:
Decidim::ComponentManifest
may becomeDecidim::Manifests::Component
Decidim::ContentBlockManifest
may become ``Decidim::Manifests::ContentBlock`3. ActionController Modules
Following the previous point, it would make sense to have a Controller namespace, that may include :
4. Menu related classes
Beta Was this translation helpful? Give feedback.
All reactions