-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Collaborative Drafts (before collaborative space) #2840
Comments
@carolromero can you put the tag of the team assigned to this issue, please? 😄 /cc @decidim/product |
I paste some initial (handmade) mockups @javierarce
|
@decidim/lot-px please check out, there is some design required here. We are re-using as much as we can and only a couple of new buttons, a card-type, icon and little else is needed unless you come up with extra ideas. |
@decidim/product I'm leaving here some questions to be clarified in the next meeting. 1st iteration questionsListing of drafts
Draft Detail
Metadata box
Authoring
Edition
Design required for
|
@xabier @arnaumonty Ok, in terms of elements the drafts seem ok. I'm not sure of the placement of the edit, collaborate, and publish buttons, though. I'll wait until @tramuntanal questions are answered, I share some of his doubts regarding the metadata box. |
I don't think we need to design a new M-Card for this. All the elements we need are already designed and implemented, we just need to hide elements we don't need: I'd say to show "Draft" instead of "Accepted", use the color for the "Sin respuesta" state, hide the progress bar, and say "View" instead of "apoyar/support". |
I'll add another questions:
|
The collaborative space should work on initiatives too. Here's there are two ways to proceed:
We forget it. We should have it on the draft page, but not in the M card. @javierarce can you add this number in the design?
Yes, open/closed/withdrawn
When a draft is published as a proposal, the state change to "closed". the creator of the draft can "withdrawn" the draft.
The draft should heritage the category.
The control version is generated by X changes and can be one or more changes in the same action, the number of review-contributions is the number of contributions done it by different authors. @xabier can you clarify this?
Yes it should
@javierarce should provide the design.
The number of meetings where the draft has been discussed. The relation between meetings and drafts works as the relation between proposals and meetings.
It becames a co-author who can edit the draft.
Yes, It should be shown in the right bar. @javierarce should include this in the design.
Just the first author.
I think we can reuse it. |
Good point. I would say just the last one.
We should always iterate on the last draft. @mrcasals can you confirm this?
I would say, attending the control version, no. @xabier what do you think?
They belong to the whole draft (proposal) |
@tramuntanal I've updated the EPIC with the specs commented this morning @javierarce we can use the M-Card for proposals attending the following different fields:
|
We have to start simple and with current features. That means with our control version system, which is simple. I am pretty sure our current control version doesn't allow to re-establish old versions. Only to compare. So MVP: participants can only publish last version. If they want to revert they can always create a new version with old content |
I think the simpler option is to consider all co-authors equal, it simplifies permissions etc. |
@decidim/product I've added a link to the MVP and a "Request collaboration Work-flow" section in the EPIC description in this page. |
About the naming of this this type of collaborative-proposal-drafts, Launchpad (software collaboration platform) uses this concept to help track the ideas/features intended to implement over the next releases: @decidim/product, @decidim/lot-core, what do you think? |
Thanks for your input @agustibr but we really want collaborative to be displayed on the name. Also blueprint has other meanings. How about simply collaborative draft ? |
@xabier, Ok |
@arnaumonty @carolromero are you ok with this? |
+1 to collaborative draft |
@decidim/lot-px @decidim/product is 1 the current follow button design or 2? I thought it was 2 but now I see 1 in your proposal #2840 (comment) |
@tramuntanal It should be the first one. I'll create an issue to update the second one. |
Design PR #3285 |
@AlberAG thanks for your input! We are aware of how good collaboration is. But this feature of Decidim is already defined, we can accommodate some input for details, but not macro-features like those present in Gdocs. Synchronous text editing, up to thousands of user is a huge challenge from the programming point of view. And this is not the functionality we are introducing here. We are not introducing anonymous contributions quite yet either. However, surveys and newsletters are already an integral part of Decidim. cheers! |
"The following action is irreversible. After publishing the draft as a proposal, the draft won't be editable anymore. The proposal won't accept new authors or contributions".
"The following action is irreversible. After publishing the draft as a proposal, the draft won't be editable anymore. The proposal won't accept new authors or contributions". |
Hi @arnaumonty, now taking a look at the closing action for drafts, to keep homogeneity in the naming, should it be named "withdraw" as it is in proposals? cc/ @decidim/product |
Maybe yes, at the beggining I thougth that It could generate misunderstunding, the behaviour is not exactly the same, but maybe we should keep the homogenity. @decidim/product thoughts? |
@arnaumonty , before renaming I'll wait for @decidim/product thoughts. By the way, the closing text for the it's the same as the publish 😅 (it must have been some mistake):
Does this seems right? After closing the draft, the draft won't be editable anymore. The draft won't accept new authors or contributions. |
@agustibr it looks good to me, I'm not sure if the behaviour is the same as other similar alerts. Please, @decidim/lot-px check this in order to unify this kind of designs. |
To keep consistency, please refer to this designs, for instance:
Always there are any modal, let's use PD: Buttons are ok like you've implemented, the links have old designs for that. |
ok, thanks @Crashillo 👍 |
It looks good to me. If you think that is necessary to keep the consistency, @Crashillo could you provide the design for these alerts? |
@Crashillo I've reviewed the modal styles, I attach a screenshot: Does it look good? |
|
Please, @Crashillo can you review the code here https://github.com/decidim/decidim/pull/3109/files#diff-8e1dc6a2bfa4fdf5aca48e1e6501aefc in the PR? it'll be easier is this file: thanks |
Review comments in PR |
This is an EPIC
Related issues: #2292
Summary
EPIC description
Decidim permits collaborative and co-creation of proposals. The proposals will be called "collaborative proposals". Each collaborative proposal will be called "draft" until be published (converted to a proposal). The collaborative proposals will have the origin "collaborative proposals". It will incorporate the following functions:
On publish a new entity is created with same title, description, category, scope and authorship, comments and the rest of the meta-information will be kept in the draft which won't disappear. Instead a link to the draft will be added to the new Proposal.
A Collaborative Draft does not have any kind of origin, nor Official, neither Citizen. This attribute will be setted to the Proposal it becomes.
Proposal limit per user: we only check it for the creation of proposal, not co-authoring of drafts.
Main related issues
Specs
Draft navigator and draft-creation button
When accessing the proposal, provided that
proposal drafts
is activated, the proposal section must:Offer a form to create a draft proposal that allows several authors (Decidim participants or user groups) to be incorporatedcreate draft
exist to create a draftDraft page and actions
Collaborate
Publish
the draft as a proposal.Creation work-flow
Request collaboration work-flow
When a non-author-user clicks on the "COLLABORATE" button she requests to become a co-author.
When the button is clicked:
From then, they are incorporated into the flow of each of the different types of proposals.
1st Iteration
design-required
Fridge
2nd Iteration
The text was updated successfully, but these errors were encountered: