Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in viewing comments on Last Activity (HOME) #4606

Closed
Xfolchf opened this issue Dec 3, 2018 · 3 comments
Closed

Error in viewing comments on Last Activity (HOME) #4606

Xfolchf opened this issue Dec 3, 2018 · 3 comments
Assignees
@oriolgual
Labels
type: bug Issues that describe a bug

Comments

@Xfolchf
Copy link

Xfolchf commented Dec 3, 2018

Describe the bug
In the section of the last activat (Home) it is not displayed correctly that activity of comments type that have mentions realized to other users

https://meta.decidim.org/processes/bug-report/f/210/proposals/13403

Screenshots
If applicable, add screenshots to help explain your problem.
image
@Xfolchf Xfolchf added the type: bug Issues that describe a bug label Dec 3, 2018
@mrcasals
Copy link
Contributor

mrcasals commented Dec 3, 2018

We should add the text-ellipsis CSS class there

@oriolgual
Copy link
Contributor

oriolgual commented Dec 3, 2018 •
edited

I don't think this is the problem @mrcasals, we should use the presenter for the content the same way we do at ProposalActivityCell or MeetingActivityCell

@mrcasals
Copy link
Contributor

mrcasals commented Dec 3, 2018

Ah, true! I didn't read the description and thought the error was with the resource name link...

oriolgual added a commit that referenced this issue Dec 3, 2018
@oriolgual
Correctly render comments activity with mentions. Closes #4606
a7119da
@oriolgual oriolgual mentioned this issue Dec 3, 2018
Merged
2 tasks
@ghost ghost assigned oriolgual Dec 3, 2018
@ghost ghost added the status: WIP label Dec 3, 2018
oriolgual added a commit that referenced this issue Dec 3, 2018
@oriolgual
Correctly render comments activity with mentions (#4612)
431707d 
* Correctly render comments activity with mentions. Closes #4606

* Add CHANGELOG
@ghost ghost removed the status: WIP label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oriolgual oriolgual

Labels
type: bug Issues that describe a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oriolgual @mrcasals @Xfolchf