Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trix instead of quill.js #4981

Closed
mrcasals opened this issue Mar 19, 2019 · 9 comments
Closed

Use trix instead of quill.js #4981

mrcasals opened this issue Mar 19, 2019 · 9 comments
Labels

Comments

@mrcasals
Copy link
Contributor

As explained in #4873, quill.js is giving us problems. I suggest we move to https://github.com/basecamp/trix, which is the default one in Rails 6 and also would enable us to properly implement #4595, even if we don't use ActiveStorage

@stale
Copy link

stale bot commented May 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in.

@stale stale bot added the wontfix label May 18, 2019
@tramuntanal
Copy link
Contributor

Don't close as Rails 6 is coming!

@stale stale bot removed the wontfix label May 20, 2019
@mrcasals
Copy link
Contributor Author

@tramuntanal trix is already open-source, so no need to wait for it to start moving the text editors! 😄

@tramuntanal
Copy link
Contributor

Yes @mrcasals but Rails 6 also comes with ActionText that ties Trix with other parts of the framework. But I haven't checked it yet, maybe you are right and development may start without ActionText 😄

I was just wanting to stop the robot from closing the issue

@carolromero
Copy link
Member

hey @mrcasals @tramuntanal I'm excited to see activity in this issue, needless to say that it's probably the most desired functionality of Decidim. 😍
@tramuntanal if you take a look at it, do you think it could go into the original request of the Generalitat?

@tramuntanal
Copy link
Contributor

Hi @carolromero , there's nothing related with rich text in CodiTramuntana's current developments :(
but we'll propose it from now on.

@stale
Copy link

stale bot commented Jul 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in.

@stale stale bot added the wontfix label Jul 27, 2019
@stale stale bot closed this as completed Aug 3, 2019
@ahukkanen
Copy link
Contributor

Is there any active discussion about the Rails 6 upgrade for Decidim?

I am particularly eagerly waiting for the upgrade in order to move to Trix and improve the rich text editor capabilities in Decidim.

@carolromero
Copy link
Member

carolromero commented Nov 14, 2019

Hello @ahukkanen,

We did discuss it because of this improvement we're making now: #5451
The conclusion was that Trix would indeed be the natural evolution once we upgrade to Rails 6. But it's not clear yet when we're going to do that upgrade. The development team thinks it's best to wait a reasonable amount of time before taking that step.

Maybe @andreslucena or @tramuntanal want to chime in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants