Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable RSpec/RepeatedExampleGroupDescription #6499

Closed
tramuntanal opened this issue Sep 7, 2020 · 3 comments · Fixed by #8704
Closed

Re-enable RSpec/RepeatedExampleGroupDescription #6499

tramuntanal opened this issue Sep 7, 2020 · 3 comments · Fixed by #8704

Comments

@tramuntanal
Copy link
Contributor

Describe the bug
PR #5785 disabled the RSpec/RepeatedExampleGroupDescription cop, but it is a good way to reduce duplicated code in rspec tests.

To enable this cop, we will require some dedication to extract common code in tests, but I think it is worth it to reduce the amount of rspec code.

To Reproduce
Steps to reproduce the behavior: N/A

Expected behavior
I would like to be advised when some tests contains repeated example groups, usually due to copy+pastes.

Screenshots
N/A

Stacktrace
N/A

Extra data (please complete the following information):
N/A

Additional context
Add any other context about the problem here. For instance, add Metadecidim link.

@stale
Copy link

stale bot commented Nov 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @andreslucena feel free to chime in.

@stale stale bot added the wontfix label Nov 7, 2020
@tramuntanal
Copy link
Contributor Author

I find this cop interesting, don't close stale-bot!

@stale stale bot closed this as completed Dec 25, 2020
@tramuntanal
Copy link
Contributor Author

This is still pending stale-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants